fix: search on team availiability (for non-org users)#19738
Merged
eunjae-lee merged 1 commit intomainfrom Mar 5, 2025
Merged
Conversation
dosubot
bot
added
teams
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/05/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (03/05/25)1 label was added to this PR based on Keith Williams's automation. |
eunjae-lee
commented
Mar 5, 2025
| ], | ||
| } | ||
| : {}), | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This is where we fetch team ids where the user belongs to, but we don't have to filter teams with the search string. It's wrong. The filtering should happen later when fetching members from these teams. We already have the logic there, meaning we have duplicated filtering here.
alishaz-polymath
approved these changes
Mar 5, 2025
Contributor
E2E results are ready! |
itsalam
pushed a commit
to itsalam/cal.com
that referenced
this pull request
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes search on the team availability page for non-org users.
Visual Demo (For contributors especially)
Search used to fail like this in a certain condition (more details in the code review)
Screenshot.2025-03-05.at.11.12.13.mp4
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
main, try to search on /availability?type=team (in a non-org account). It should fail with console error.