fix: make strict bottom position of DateRangePicker optional#19768
Merged
anikdhabal merged 3 commits intocalcom:mainfrom Mar 5, 2025
Merged
fix: make strict bottom position of DateRangePicker optional#19768anikdhabal merged 3 commits intocalcom:mainfrom
anikdhabal merged 3 commits intocalcom:mainfrom
Conversation
|
@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/05/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (03/05/25)1 label was added to this PR based on Keith Williams's automation. |
vijayraghav-io
commented
Mar 5, 2025
| sideOffset={4} | ||
| side="bottom" | ||
| avoidCollisions={false}> | ||
| avoidCollisions={!strictlyBottom}> |
Contributor
Author
There was a problem hiding this comment.
eventhough side="bottom", avoidCollisions if set to true, will position the popover at the top if there is any collisions,
If we want to strictly position at the bottom avoidCollisions should be false
anikdhabal
approved these changes
Mar 5, 2025
Contributor
Author
|
Thank you! @anikdhabal 🙏 |
Contributor
E2E results are ready! |
itsalam
pushed a commit
to itsalam/cal.com
that referenced
this pull request
Mar 6, 2025
…19768) * make strictbottom optional * chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ref:#19717 (comment)