Skip to content

chore: rename virtual-queue to router-position#19774

Merged
retrogtx merged 2 commits intocalcom:mainfrom
Neon-20:chore/rename
Mar 6, 2025
Merged

chore: rename virtual-queue to router-position#19774
retrogtx merged 2 commits intocalcom:mainfrom
Neon-20:chore/rename

Conversation

@Neon-20
Copy link
Copy Markdown
Contributor

@Neon-20 Neon-20 commented Mar 5, 2025

What does this PR do?

/claim #19773

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change
Before

WhatsApp Image 2025-03-06 at 03 07 11

After

WhatsApp Image 2025-03-06 at 03 04 50

Video Demo (if applicable):

** https://www.loom.com/share/862cc62af68a4976b0c73f77fa5afd82?sid=a96c5845-6d7a-4186-b69f-b911895088be **

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 5, 2025

@Neon-20 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Mar 5, 2025
@graphite-app graphite-app bot requested a review from a team March 5, 2025 21:29
@github-actions github-actions bot added ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🐛 bug Something isn't working labels Mar 5, 2025
@dosubot dosubot bot added this to the Community Only milestone Mar 5, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app bot commented Mar 5, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/05/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/05/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/06/25)

1 label was added to this PR based on Keith Williams's automation.

Copy link
Copy Markdown
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the page before with virtual-queues still in place
image

This is the page now:
image

@retrogtx
Copy link
Copy Markdown
Contributor

retrogtx commented Mar 6, 2025

Also, the format of this PR is not right. the bounty bot has not detected it, so you might want check that!

@algora-pbc
Copy link
Copy Markdown

algora-pbc bot commented Mar 6, 2025

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe.

@Neon-20
Copy link
Copy Markdown
Contributor Author

Neon-20 commented Mar 6, 2025

This was the page before with virtual-queues still in place image

This is the page now: image

I have uploaded a loom video, check it out!!
@retrogtx

@retrogtx
Copy link
Copy Markdown
Contributor

retrogtx commented Mar 6, 2025

I don't see a loom video, just the two images

@Neon-20
Copy link
Copy Markdown
Contributor Author

Neon-20 commented Mar 6, 2025

I don't see a loom video, just the two images

Missed it, check now please !! @retrogtx

@retrogtx retrogtx changed the title chore(fix): rename virtual-queue to router-position chore: rename virtual-queue to router-position Mar 6, 2025
Copy link
Copy Markdown
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx for the pr!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2025

E2E results are ready!

@retrogtx retrogtx merged commit 56d1998 into calcom:main Mar 6, 2025
35 of 59 checks passed
itsalam pushed a commit to itsalam/cal.com that referenced this pull request Mar 6, 2025
Co-authored-by: amrit <iamamrit27@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Bounty claim 🐛 bug Something isn't working community Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-5267] chore: rename "virtual-queues" to "router-position"

2 participants