Skip to content

chore: migrate two-factor APIs to app router#19826

Merged
hbjORbj merged 8 commits intomainfrom
chore/migrate-api-two-factor
Mar 9, 2025
Merged

chore: migrate two-factor APIs to app router#19826
hbjORbj merged 8 commits intomainfrom
chore/migrate-api-two-factor

Conversation

@hbjORbj
Copy link
Copy Markdown
Contributor

@hbjORbj hbjORbj commented Mar 7, 2025

What does this PR do?

  • Migrating /api/two-factor apis to app router

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Please use the latest Vercel preview and test please 🙏.

@graphite-app graphite-app Bot requested a review from a team March 7, 2025 09:56
@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 7, 2025
@hbjORbj hbjORbj changed the title chore: migrate api two factor chore: migrate two-factor APIs to app router Mar 7, 2025
@dosubot dosubot Bot added the authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in label Mar 7, 2025
@hbjORbj hbjORbj requested a review from sean-brydon March 7, 2025 09:56
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 9, 2025 3:22pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 9, 2025 3:22pm

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 7, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/07/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@@ -1,66 +0,0 @@
import type { NextApiRequest, NextApiResponse } from "next";
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left: App Router code

Right: Pages Router code

Screenshot 2025-03-07 at 5 03 24 AM

Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Another one bites the dust

@hbjORbj hbjORbj merged commit 1f1862e into main Mar 9, 2025
@hbjORbj hbjORbj deleted the chore/migrate-api-two-factor branch March 9, 2025 15:40
ThyMinimalDev pushed a commit that referenced this pull request Mar 13, 2025
* wip

* remove comment

* clean up

* clean up

---------

Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication area: authentication, auth, google sign in, password, SAML, password reset, can't log in consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants