fix: don't remind platform users in reminder cron#20056
Merged
ThyMinimalDev merged 3 commits intoMar 17, 2025
Conversation
keithwillcode
added
core
dosubot
Bot
added
bookings
ThyMinimalDev
commented
Mar 13, 2025
Comment on lines
+75
to
+80
| const bookingsToRemind = bookings.filter( | ||
| (booking) => | ||
| !booking.user || | ||
| !booking.user.isPlatformManaged || | ||
| (booking.user.isPlatformManaged && Boolean(booking.user.platformOAuthClients?.[0]?.areEmailsEnabled)) | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
don't remind platform users for which the oauth client has disabled emails
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add platform team as reviewer" took an action on this PR • (03/13/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (03/17/25)1 label was added to this PR based on Keith Williams's automation. |
Udit-takkar
approved these changes
Mar 17, 2025
Contributor
E2E results are ready! |
ThyMinimalDev
deleted the
fix-booking-reminder-cron-for-platform-managed-user
branch
ThyMinimalDev
added a commit
that referenced
this pull request
Mar 19, 2025
This reverts commit dd45d8c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The code filters a list of bookings, including those without user information, those with users not platform-managed, or platform-managed users where email reminders are getting reminded of the booking.
#19694
Mandatory Tasks (DO NOT REMOVE)