Skip to content

fix: German translation for seats_availability text#20086

Merged
TusharBhatt1 merged 4 commits into
calcom:mainfrom
ajayjha1:fix-german-seat-translation
Mar 15, 2025
Merged

fix: German translation for seats_availability text#20086
TusharBhatt1 merged 4 commits into
calcom:mainfrom
ajayjha1:fix-german-seat-translation

Conversation

@ajayjha1
Copy link
Copy Markdown
Contributor

@ajayjha1 ajayjha1 commented Mar 14, 2025

Fixes incorrect German translation for seat availability text.

Issue

When setting a seat limitation to 1, it showed "1 seats_available" instead of "1 Platz verfügbar".
When changing to 2 seats, it showed "2 plätze verfügbare" instead of "2 Plätze verfügbar".

Fix

Added proper German singular/plural translations with correct grammar:

  • seats_available_one: "Platz verfügbar"
  • seats_available_other: "Plätze verfügbar"

This ensures the count is displayed with the correct grammatical form in German.

##For 1 needs to be fixed for other languages too currently shows "1 seats_available" instead of "1 Available"
Fixes #20016

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 14, 2025

@ajayjha1 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app Bot added the community Created by Linear-GitHub Sync label Mar 14, 2025
@graphite-app graphite-app Bot requested a review from a team March 14, 2025 12:04
@github-actions github-actions Bot added i18n area: i18n, translations Low priority Created by Linear-GitHub Sync labels Mar 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 14, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix: German translation for seats_availability text". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 14, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/14/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (03/14/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/15/25)

1 label was added to this PR based on Keith Williams's automation.

@ajayjha1 ajayjha1 changed the title Fix German translation for seats_availability text Fix: German translation for seats_availability text Mar 14, 2025
@ajayjha1 ajayjha1 changed the title Fix: German translation for seats_availability text fix: German translation for seats_availability text Mar 14, 2025
Comment thread apps/web/public/static/locales/de/common.json Outdated
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 15, 2025

CLA assistant check
All committers have signed the CLA.

TusharBhatt1
TusharBhatt1 previously approved these changes Mar 15, 2025
@TusharBhatt1 TusharBhatt1 enabled auto-merge (squash) March 15, 2025 07:49
@TusharBhatt1 TusharBhatt1 dismissed their stale review March 15, 2025 07:54

Minor change to add

@TusharBhatt1 TusharBhatt1 merged commit 5d2d7ce into calcom:main Mar 15, 2025
@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

ajayjha1 added a commit to ajayjha1/cal.com that referenced this pull request Mar 15, 2025
@ajayjha1
Copy link
Copy Markdown
Contributor Author

@TusharBhatt1 "seats_available_one": "Platz verfügbar" missed in German translation file.

@TusharBhatt1
Copy link
Copy Markdown
Contributor

@TusharBhatt1 "seats_available_one": "Platz verfügbar" missed in German translation file.

It was missing throughout all languages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Created by Linear-GitHub Sync i18n area: i18n, translations Low priority Created by Linear-GitHub Sync ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-5299] Issue with German translation.

3 participants