Skip to content

perf: Remove slots router from publicViewer#20128

Merged
keithwillcode merged 1 commit into
mainfrom
perf/remove-slots-from-public-router
Mar 17, 2025
Merged

perf: Remove slots router from publicViewer#20128
keithwillcode merged 1 commit into
mainfrom
perf/remove-slots-from-public-router

Conversation

@keithwillcode
Copy link
Copy Markdown
Contributor

What does this PR do?

Loading slots pulls in loads of dependencies, which being on the publicViewer means that for any of those tRPC calls, we were compiling loads of things we may have never used.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Ensure all tests pass
  • Ensure loading booking pages to get slots works fine.

@keithwillcode keithwillcode self-assigned this Mar 17, 2025
@graphite-app graphite-app Bot requested a review from a team March 17, 2025 11:46
@keithwillcode keithwillcode added core area: core, team members only foundation labels Mar 17, 2025
@dosubot dosubot Bot added bookings area: bookings, availability, timezones, double booking performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive labels Mar 17, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Mar 17, 2025 11:49am
calcom-web-canary ⬜️ Ignored (Inspect) Mar 17, 2025 11:49am

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 17, 2025

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (03/17/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

E2E results are ready!

@keithwillcode keithwillcode enabled auto-merge (squash) March 17, 2025 14:45
@keithwillcode keithwillcode merged commit 3be9e1b into main Mar 17, 2025
@keithwillcode keithwillcode deleted the perf/remove-slots-from-public-router branch March 17, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bookings area: bookings, availability, timezones, double booking core area: core, team members only foundation performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants