fix: Salesforce Stricter Website querying to prevent wrong account match during contact owner check#20133
Merged
Merged
Conversation
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
keithwillcode
added
core
hariombalhara
force-pushed
the
fix-salesforce-stricter-website-query
branch
from
e4af00f to
b5a6b3a
Compare
hariombalhara
commented
Mar 17, 2025
| const account = accountQuery.records[0] as { Id: string; Website: string }; | ||
| log.info( | ||
| "Found account based on email domain", | ||
| safeStringify({ emailDomain, accountWebsite: account.Website, accountId: account.Id }) |
Member
Author
There was a problem hiding this comment.
Logging Website and accountId both it can confirm that when we matched what Website value was there for the account
hariombalhara
commented
Mar 17, 2025
| const crmService = new SalesforceCRMService(credential, appOptions); | ||
| const account1OwnerEmail = "contact-account-owner1@example.com"; | ||
| const account2OwnerEmail = "contact-account-owner2@example.com"; | ||
| const account1OwnerEmail = "account1-owner@example.com"; |
hariombalhara
changed the title
hariombalhara
changed the title
dosubot
Bot
added
crm-apps
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/17/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (03/17/25)1 label was added to this PR based on Keith Williams's automation. |
keithwillcode
approved these changes
Mar 17, 2025
Contributor
E2E results are ready! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Followup of #19799