Skip to content

fix: Salesforce - fallback to creating lead#20137

Merged
keithwillcode merged 9 commits into
mainfrom
fallback-to-creating-lead
Mar 18, 2025
Merged

fix: Salesforce - fallback to creating lead#20137
keithwillcode merged 9 commits into
mainfrom
fallback-to-creating-lead

Conversation

@joeauyeung
Copy link
Copy Markdown
Contributor

@joeauyeung joeauyeung commented Mar 17, 2025 •
edited
Loading

What does this PR do?

  • Fixes when the option to create events on leads and to create a contact if an account exists are both enabled, then create a lead

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Set create events on to lead
  • Enable the option to create a contact under an account if it exists
  • Create a booking with an email associated with an account
    • A contact should be created
  • Create a booking with an email not associated with an account
    • A lead should be created

@graphite-app graphite-app Bot requested a review from a team March 17, 2025 15:05
@keithwillcode keithwillcode added consumer core area: core, team members only labels Mar 17, 2025
@dosubot dosubot Bot added crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid 🐛 bug Something isn't working labels Mar 17, 2025
joeauyeung
joeauyeung commented Mar 17, 2025
View reviewed changes
Comment thread packages/app-store/salesforce/lib/CrmService.ts
}
} else {
log.info(
"createEventOn=LEAD, No account found for attendee, not creating a contact",
Copy link
Copy Markdown
Contributor Author

@joeauyeung joeauyeung Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leads don't need to be associated with an account

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 17, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/17/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 8:33am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Mar 18, 2025 8:33am

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 17, 2025 •
edited
Loading

E2E results are ready!

@keithwillcode keithwillcode enabled auto-merge (squash) March 17, 2025 20:34
hariombalhara
hariombalhara previously approved these changes Mar 18, 2025
View reviewed changes
@keithwillcode keithwillcode merged commit e9f20b1 into main Mar 18, 2025
@keithwillcode keithwillcode deleted the fallback-to-creating-lead branch March 18, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

Assignees

No one assigned

Labels

🐛 bug Something isn't working consumer core area: core, team members only crm-apps area: crm apps, salesforce, hubspot, close.com, sendgrid ready-for-e2e

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joeauyeung @hariombalhara @keithwillcode