Skip to content

fix: add documentation to the possible values of :app in conferencing controller#20164

Merged
keithwillcode merged 2 commits into
mainfrom
fix-conferencing-app-documentatiuon
Mar 18, 2025
Merged

fix: add documentation to the possible values of :app in conferencing controller#20164
keithwillcode merged 2 commits into
mainfrom
fix-conferencing-app-documentatiuon

Conversation

@ibex088
Copy link
Copy Markdown
Contributor

@ibex088 ibex088 commented Mar 18, 2025

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

@ibex088 ibex088 requested a review from a team March 18, 2025 11:24
@ibex088 ibex088 requested a review from a team as a code owner March 18, 2025 11:24
@graphite-app graphite-app Bot requested a review from a team March 18, 2025 11:24
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal 🛑 Canceled (Inspect) Mar 18, 2025 8:51pm
calcom-web-canary 🛑 Canceled (Inspect) Mar 18, 2025 8:51pm

@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Mar 18, 2025
@dosubot dosubot Bot added the docs area: docs, documentation, cal.com/docs label Mar 18, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Mar 18, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/18/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (03/18/25)

1 label was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 18, 2025

E2E results are ready!

@keithwillcode keithwillcode merged commit 413aba6 into main Mar 18, 2025
@keithwillcode keithwillcode deleted the fix-conferencing-app-documentatiuon branch March 18, 2025 20:41
@vercel vercel Bot temporarily deployed to Preview – cal March 18, 2025 20:50 Inactive
@vercel vercel Bot temporarily deployed to Preview – calcom-web-canary March 18, 2025 20:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only docs area: docs, documentation, cal.com/docs platform Anything related to our platform plan ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants