feat: refactor handleCancelBooking to not have next request by sean-brydon · Pull Request #20241 · calcom/cal.diy

sean-brydon · 2025-03-20T09:06:02Z

What does this PR do?

Removes the next request from a code function that is used in other frameworks outside of next

Fixes: #20374

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

Show screen recordings of the issue or feature.
Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

Add side-by-side screenshots of the original and updated change.
Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

vercel · 2025-03-20T09:09:32Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Apr 1, 2025 2:24pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		Apr 1, 2025 2:24pm

graphite-app · 2025-03-20T09:10:10Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (03/20/25)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2025-03-20T10:28:38Z

E2E results are ready!

Workflow #54901.1 latest results

joeauyeung

Awesome refactor and the changes look good. Looks like API V2 tests need to be updated.

socket-security · 2025-04-01T09:49:28Z

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher

View full report↗︎

emrysal · 2025-04-01T14:16:12Z

  const result = await handleCancelBooking({
-    appDirRequestBody,
+    bookingData,
    userId: session?.user?.id || -1,


Our of scope, but we should return early when there's no logged in user or not care.

emrysal · 2025-04-01T14:17:07Z

  const seatReference = bookingToDelete.seatsReferences.find(
    (reference) => reference.referenceUid === seatReferenceUid
  );
+  console.log("seatReference", seatReference);


emrysal

LGTM 🚀 - nice one

refactor handleCancelBooking to not have next request

23fcd2d

sean-brydon requested a review from a team as a code owner March 20, 2025 09:06

sean-brydon requested a review from a team March 20, 2025 09:06

graphite-app Bot requested a review from a team March 20, 2025 09:06

keithwillcode added consumer core area: core, team members only labels Mar 20, 2025

dosubot Bot added bookings area: bookings, availability, timezones, double booking 💻 refactor labels Mar 20, 2025

vercel Bot deployed to Preview – api March 20, 2025 09:14 View deployment

vercel Bot deployed to Preview – dev March 20, 2025 09:23 View deployment

fix platform v2 function calls

53a5a75

vercel Bot deployed to Preview – api March 20, 2025 09:34 View deployment

vercel Bot deployed to Preview – dev March 20, 2025 09:43 View deployment

dont fall back to "" if no seat refrence

1aee98f

vercel Bot deployed to Preview – api March 20, 2025 09:54 View deployment

sean-brydon added the ready-for-e2e label Mar 20, 2025

vercel Bot deployed to Preview – dev March 20, 2025 10:01 View deployment

Merge branch 'main' into feat/cancel-new-booking-extract-req

ba42622

vercel Bot deployed to Preview – api March 20, 2025 13:44 View deployment

vercel Bot deployed to Preview – dev March 20, 2025 13:50 View deployment

Merge branch 'main' into feat/cancel-new-booking-extract-req

c8d7281

vercel Bot deployed to Preview – api March 20, 2025 20:16 View deployment

vercel Bot deployed to Preview – dev March 20, 2025 20:23 View deployment

joeauyeung requested changes Mar 24, 2025

View reviewed changes

dosubot Bot added this to the v5.2 milestone Mar 26, 2025

Merge branch 'main' into feat/cancel-new-booking-extract-req

26938c6

vercel Bot had a problem deploying to Preview – api April 1, 2025 09:05 Failure

add missing type from merge

6e893f8

vercel Bot deployed to Preview – api April 1, 2025 09:29 View deployment

supalarry and others added 2 commits April 1, 2025 11:38

Merge branch 'main' into feat/cancel-new-booking-extract-req

5461bc0

chore: bump platform libraries

08bb9e9

vercel Bot deployed to Preview – api April 1, 2025 09:46 View deployment

vercel Bot deployed to Preview – api April 1, 2025 09:56 View deployment

supalarry previously approved these changes Apr 1, 2025

View reviewed changes

supalarry requested a review from joeauyeung April 1, 2025 10:29

supalarry enabled auto-merge (squash) April 1, 2025 10:29

vercel Bot deployed to Preview – dev April 1, 2025 10:31 View deployment

lock file updates

4776e8f

sean-brydon dismissed supalarry’s stale review via 4776e8f April 1, 2025 11:59

supalarry self-requested a review April 1, 2025 12:02

supalarry previously approved these changes Apr 1, 2025

View reviewed changes

vercel Bot deployed to Preview – api April 1, 2025 12:09 View deployment

vercel Bot deployed to Preview – dev April 1, 2025 12:16 View deployment

joeauyeung previously approved these changes Apr 1, 2025

View reviewed changes

emrysal reviewed Apr 1, 2025

View reviewed changes

Comment thread packages/features/bookings/lib/handleSeats/cancel/cancelAttendeeSeat.ts Outdated

Delete rogue console.log

d2d2b73

emrysal dismissed stale reviews from joeauyeung and supalarry via d2d2b73 April 1, 2025 14:19

emrysal approved these changes Apr 1, 2025

View reviewed changes

Merge branch 'main' into feat/cancel-new-booking-extract-req

ae978e9

vercel Bot deployed to Preview – api April 1, 2025 14:39 View deployment

vercel Bot had a problem deploying to Preview – dev April 1, 2025 14:48 Failure

supalarry merged commit f94e805 into main Apr 1, 2025
37 of 38 checks passed

supalarry deleted the feat/cancel-new-booking-extract-req branch April 1, 2025 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: refactor handleCancelBooking to not have next request#20241

feat: refactor handleCancelBooking to not have next request#20241
supalarry merged 12 commits intomainfrom
feat/cancel-new-booking-extract-req

sean-brydon commented Mar 20, 2025 •

edited

Loading

Uh oh!

vercel Bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

graphite-app Bot commented Mar 20, 2025

Uh oh!

github-actions Bot commented Mar 20, 2025 •

edited

Loading

Uh oh!

joeauyeung left a comment

Uh oh!

socket-security Bot commented Apr 1, 2025 •

edited

Loading

Uh oh!

emrysal Apr 1, 2025

Uh oh!

emrysal Apr 1, 2025

Uh oh!

Uh oh!

emrysal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

sean-brydon commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Visual Demo (For contributors especially)

Video Demo (if applicable):

Image Demo (if applicable):

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Uh oh!

vercel Bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app Bot commented Mar 20, 2025

Graphite Automations

Uh oh!

github-actions Bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

joeauyeung left a comment

Choose a reason for hiding this comment

Uh oh!

socket-security Bot commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emrysal Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

emrysal Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sean-brydon commented Mar 20, 2025 •

edited

Loading

vercel Bot commented Mar 20, 2025 •

edited

Loading

github-actions Bot commented Mar 20, 2025 •

edited

Loading

socket-security Bot commented Apr 1, 2025 •

edited

Loading