Skip to content

fix: add missing DataTableProvider#20473

Merged
sean-brydon merged 2 commits intomainfrom
fix/column-resizing
Apr 1, 2025
Merged

fix: add missing DataTableProvider#20473
sean-brydon merged 2 commits intomainfrom
fix/column-resizing

Conversation

@eunjae-lee
Copy link
Copy Markdown
Contributor

@eunjae-lee eunjae-lee commented Apr 1, 2025

What does this PR do?

This PR adds missing DataTableProvider to components where DataTable is being used.

There has been an internal change within DataTable that always requires DataTableProvider, which has caused this issue.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

e2e test has been added

@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 1, 2025
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 9:07am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 9:07am

@eunjae-lee eunjae-lee marked this pull request as ready for review April 1, 2025 09:14
@graphite-app graphite-app Bot requested a review from a team April 1, 2025 09:14
@dosubot dosubot Bot added automated-tests area: unit tests, e2e tests, playwright 🐛 bug Something isn't working labels Apr 1, 2025
@@ -0,0 +1,41 @@
import { expect } from "@playwright/test";
Copy link
Copy Markdown
Contributor Author

@eunjae-lee eunjae-lee Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for AvailabilitySliderTable, but I couldn't add one for GroupTeamMappingTable.

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 1, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/01/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2025

E2E results are ready!

@sean-brydon sean-brydon merged commit 1d9d52e into main Apr 1, 2025
106 of 110 checks passed
@sean-brydon sean-brydon deleted the fix/column-resizing branch April 1, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-tests area: unit tests, e2e tests, playwright 🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants