Skip to content

fix: form builder dark mode#20474

Merged
sean-brydon merged 1 commit intomainfrom
feat/checkbox-checked-state-v2
Apr 1, 2025
Merged

fix: form builder dark mode#20474
sean-brydon merged 1 commit intomainfrom
feat/checkbox-checked-state-v2

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

What does this PR do?

Duplicate of #19820 but without being in merge conflict hell

Before
CleanShot 2025-04-01 at 10 02 46@2x

After
CleanShot 2025-04-01 at 10 02 54@2x
CleanShot 2025-04-01 at 10 02 50@2x

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@graphite-app graphite-app Bot requested a review from a team April 1, 2025 09:03
@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 1, 2025
@dosubot dosubot Bot added ui area: UI, frontend, button, form, input 🐛 bug Something isn't working labels Apr 1, 2025
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 1, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/01/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (04/01/25)

1 label was added to this PR based on Keith Williams's automation.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Apr 1, 2025 9:09am
calcom-web-canary ⬜️ Ignored (Inspect) Apr 1, 2025 9:09am

@sean-brydon sean-brydon enabled auto-merge (squash) April 1, 2025 09:11
@sean-brydon sean-brydon merged commit f1a8329 into main Apr 1, 2025
76 of 81 checks passed
@sean-brydon sean-brydon deleted the feat/checkbox-checked-state-v2 branch April 1, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working consumer core area: core, team members only ready-for-e2e ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants