Resync yarn.lock. Adding some peer deps for turbo packages/*#2262
Merged
Conversation
|
@denik1981 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/3VRnZUiw4VYemabfD5WFUmSyDoKt [Deployment for 7cf2a4f canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/45VC7t524nNcBaANxGvV2VYvSZ4o |
denik1981
changed the title
packages/*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resyncs
yarn.lockthat is out of sync frommain.Add a few peer dependencies to their respective host packages to reduce console noise for a cleaner dx installation.
Assures
@calcom/prismacan be installed as a standalone package will all its peer dependencies (adding zod dep to itself) so it can be consumed in the future by a different app.NOTE ASIDE FOR PEER DEPS:
Some peer dependencies are actually added but unseen by yarn working in a monorepo when node_modules is hoisted.
Examples of such are
eslint-configrequiringnext@>=10.2.0, already added by@calcom/web, andreact-hot-toastrequiringcsstypealready added by@types/react. This might confuse the developer but we cannot do anything about that.Workspaces can only be enabled in private projectsIf you wonder what this means from your
yarn install, it is coming fromrediswhich is required as a monorepo by our SAML library. I can imagine@boxyhq/saml-jacksonis going throw a series of breaking changes (haven't reached 1.0.0 yet) but we might want to keep a close eye on it, considering it is an auth-related library and that we are adding it using the fixed form (this is understandable). There might be an important security bug fix in its recent upgrades that we would not ship unless it is manually added and merged by us.How should this be tested?
Regular regression tests to assure everything is still working well.
yarn test-e2e//prodyarn workspace @calcom/web test-e2e//dev