Conversation
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/Ep32XQn7daaDueBgWNFeN9FBebo3 [Deployment for bd865e4 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/DeLjmGAcgisbKUdqGxW95QV82x2u |
| "24_hour": "24 hour", | ||
| "redirect_success_booking": "Redirect on booking ", | ||
| "you_are_being_redirected": "You are being redirected to {{ url }} in {{ timeRemaining }} second.", | ||
| "you_are_being_redirected_plural": "You are being redirected to {{ url }} in {{ timeRemaining }} seconds.", |
There was a problem hiding this comment.
Yeah. I scratched my head for a long time. I was using _other instead of _plural as per this https://react.i18next.com/latest/trans-component.
Not sure when _plural is used and when _other
There was a problem hiding this comment.
Instead of pluralizing whole sentences let's try to pluralize single units (seconds in this case) for maximum reusability.
There was a problem hiding this comment.
Instead of pluralizing whole sentences let's try to pluralize single units (seconds in this case) for maximum reusability.
I have past experiences with translation where the whole sentence if provided can be given better translation. Not very sure of it's the right approach.
Would follow what you suggested for now, till I have solid reasoning.
There was a problem hiding this comment.
@hariombalhara agreed that there will be exceptions but "seconds" I don't think is one of them
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
Simplified translation and added Spanish example to test it.
3 participants
What does this PR do?
Fixes #2384
Adds translation for redirect text
Type of change
How should this be tested?
Checklist