fix: disable recording streaming in cal video#24460
Conversation
WalkthroughThe change modifies configuration defaults in packages/app-store/dailyvideo/lib/VideoApiAdapter.ts. The allow_streaming_from_bucket flag is set from true to false in two code paths: during translateEvent when enabling cloud storage, and in createInstantMeeting. No additional logic, control flow, or other settings were altered. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3)**/*.ts📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Files:
**/*.{ts,tsx,js,jsx}⚙️ CodeRabbit configuration file
Files:
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
E2E results are ready! |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
What does this PR do?
In some scenarios the cal video download link takes a lot of time to load especially when it's big in size
with
allow_streaming_from_bucketas false we won't show the video player and video would be downloaded automaticallyYou can refer https://docs.daily.co/reference/rest-api/recordings/get-recording-link#main
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?