Skip to content

fix: disable recording streaming in cal video#24460

Merged
Udit-takkar merged 2 commits into
mainfrom
fix/disable-stream
Oct 14, 2025
Merged

fix: disable recording streaming in cal video#24460
Udit-takkar merged 2 commits into
mainfrom
fix/disable-stream

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

@Udit-takkar Udit-takkar commented Oct 14, 2025

What does this PR do?

In some scenarios the cal video download link takes a lot of time to load especially when it's big in size

Screenshot 2025-10-14 at 11 13 17 PM

with allow_streaming_from_bucket as false we won't show the video player and video would be downloaded automatically

You can refer https://docs.daily.co/reference/rest-api/recordings/get-recording-link#main

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

@graphite-app graphite-app Bot requested a review from a team October 14, 2025 17:44
@keithwillcode keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Oct 14, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 14, 2025

Walkthrough

The change modifies configuration defaults in packages/app-store/dailyvideo/lib/VideoApiAdapter.ts. The allow_streaming_from_bucket flag is set from true to false in two code paths: during translateEvent when enabling cloud storage, and in createInstantMeeting. No additional logic, control flow, or other settings were altered.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the core change of disabling streaming for recorded videos in the Cal video feature, matching the code adjustment of setting allow_streaming_from_bucket to false, and is free of extraneous details.
Description Check ✅ Passed The description clearly outlines the purpose of disabling streaming to force downloads for large recordings, references the relevant API behavior, includes context about performance issues and a screenshot, and directly relates to the code change.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/disable-stream

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b5585b3 and b1d0f6a.

📒 Files selected for processing (1)
  • packages/app-store/dailyvideo/lib/VideoApiAdapter.ts (2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

**/*.ts: For Prisma queries, only select data you need; never use include, always use select
Ensure the credential.key field is never returned from tRPC endpoints or APIs

Files:

  • packages/app-store/dailyvideo/lib/VideoApiAdapter.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

  • packages/app-store/dailyvideo/lib/VideoApiAdapter.ts
**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.

Files:

  • packages/app-store/dailyvideo/lib/VideoApiAdapter.ts
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Install dependencies / Yarn install & cache
🔇 Additional comments (1)
packages/app-store/dailyvideo/lib/VideoApiAdapter.ts (1)

363-372: Consistent change applied.

The allow_streaming_from_bucket flag is consistently set to false here as well, matching the change in translateEvent. The same concern about hardcoding applies here.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Udit-takkar Udit-takkar changed the title fix: disble streaming fix: disable streaming in cal video Oct 14, 2025
@Udit-takkar Udit-takkar changed the title fix: disable streaming in cal video fix: disable recording streaming in cal video Oct 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 14, 2025

E2E results are ready!

@dosubot dosubot Bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working labels Oct 14, 2025
@Udit-takkar Udit-takkar enabled auto-merge (squash) October 14, 2025 21:48
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Oct 14, 2025 9:48pm
cal-eu Ignored Ignored Oct 14, 2025 9:48pm

@Udit-takkar Udit-takkar merged commit 003aaaa into main Oct 14, 2025
36 checks passed
@Udit-takkar Udit-takkar deleted the fix/disable-stream branch October 14, 2025 22:09
akarsh-jain-790 pushed a commit to akarsh-jain-790/cal.com that referenced this pull request Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO ready-for-e2e size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants