Skip to content

Styling tweaks to inputs and Select (+ TimezoneSelect)#2453

Merged
pumfleet merged 5 commits intomainfrom
feature/form-styling
Apr 14, 2022
Merged

Styling tweaks to inputs and Select (+ TimezoneSelect)#2453
pumfleet merged 5 commits intomainfrom
feature/form-styling

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Apr 9, 2022

What does this PR do?

This PR addresses inconsistencies in the design, does some cleanup, and design fixes - it's the result of a brief but in-depth investigation into react-select, tailwindcss & tailwindcss/forms, addressing the behaviour of form element focus:* classes.

Fixes #2451

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 9, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/Ab94pARw96kbEPLF5hAP4ndPJWSC
✅ Preview: https://docs-git-feature-form-styling-cal.vercel.app

[Deployment for b502286 canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/GgKTJPDsk3Vz7mN4zzneXLfaetHk
✅ Preview: https://calendso-git-feature-form-styling-cal.vercel.app

[Deployment for b502286 failed]

@vercel vercel Bot temporarily deployed to Preview – calendso April 9, 2022 20:43 Inactive
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! great for consistency

@vercel vercel Bot temporarily deployed to Preview – docs April 9, 2022 22:33 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 9, 2022 22:33 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 12, 2022 09:32 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 12, 2022 09:32 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 14, 2022 14:58 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 14, 2022 14:58 Inactive
@pumfleet pumfleet merged commit 5fdc507 into main Apr 14, 2022
@pumfleet pumfleet deleted the feature/form-styling branch April 14, 2022 14:58
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select drop down in invite dialog & role change is invalid style

3 participants