Fix all day events from Outlook allowing bookings#2464
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/6WqYqYFXJpM97rM4o7nkytCEnfA6 [Deployment for 77ec7b8 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/9JqHZMsPZNPkZq1R5FdXjQqWLZgA |
joeauyeung
commented
Apr 11, 2022
Comment on lines
-90
to
+91
| start: dayjs(a.start).subtract(currentUser.bufferTime, "minute").toString(), | ||
| end: dayjs(a.end).add(currentUser.bufferTime, "minute").toString(), | ||
| start: dayjs(a.start).subtract(currentUser.bufferTime, "minute"), | ||
| end: dayjs(a.end).add(currentUser.bufferTime, "minute"), |
Contributor
Author
There was a problem hiding this comment.
Pass dayjs object to determine unavailable times
pumfleet
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a hot fix to not allow bookings for all day events. Since busy times coming from MS Graph were in UTC, converted to a dayjs object, back to a string, it would apply the UTC offset to the time which allowed some bookings through.
Fixes issue from email thread.
Type of change
How should this be tested?