Embed behind authentication page, Floating Button Popup and other changes#2468
Merged
hariombalhara merged 15 commits intomainfrom Apr 14, 2022
Merged
Embed behind authentication page, Floating Button Popup and other changes#2468hariombalhara merged 15 commits intomainfrom
hariombalhara merged 15 commits intomainfrom
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/4KmGBv1pQHd9BsD27VBDcSoMW2XD [Deployment for 53b0931 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/HvqgGKsbF3gy69U8Rjpx3LyB6EcD |
9310a61 to
9782eab
Compare
d55b5a6 to
f77898b
Compare
zomars
approved these changes
Apr 13, 2022
Contributor
zomars
left a comment
There was a problem hiding this comment.
Code looks good. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
inlinemode also - https://www.loom.com/share/b2c4beaa9b3e4bf8be0343656a243a63* { --cal-brand-border-color: blue; --cal-brand-background-color: blue; }telemetryClientvalue being changed in context, pageViews were being recorded twice.Type of change
Checklist