Skip to content

Embed behind authentication page, Floating Button Popup and other changes#2468

Merged
hariombalhara merged 15 commits intomainfrom
enhancements/embed
Apr 14, 2022
Merged

Embed behind authentication page, Floating Button Popup and other changes#2468
hariombalhara merged 15 commits intomainfrom
enhancements/embed

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Apr 12, 2022

What does this PR do?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/4KmGBv1pQHd9BsD27VBDcSoMW2XD
✅ Preview: Canceled

[Deployment for 53b0931 canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/HvqgGKsbF3gy69U8Rjpx3LyB6EcD
✅ Preview: https://calendso-git-enhancements-embed-cal.vercel.app

@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 05:29 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 05:29 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 05:57 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 05:57 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 06:00 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 06:00 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 06:03 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 06:04 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 10:31 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 10:31 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 10:40 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 10:40 Inactive
@hariombalhara hariombalhara marked this pull request as ready for review April 13, 2022 10:44
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 10:47 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 10:47 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 11:08 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 11:08 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 11:38 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 11:38 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 11:45 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 11:45 Inactive
@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 11:46 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 11:50 Inactive
@hariombalhara hariombalhara requested review from a team, PeerRich, pumfleet and zomars and removed request for zomars April 13, 2022 11:55
@hariombalhara hariombalhara changed the title Embed behind authentication page Embed behind authentication page, Floating Button Popup and other changes Apr 13, 2022
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Nice work!

@vercel vercel Bot temporarily deployed to Preview – docs April 13, 2022 17:50 Inactive
@vercel vercel Bot temporarily deployed to Preview – calendso April 13, 2022 17:50 Inactive
@hariombalhara hariombalhara merged commit 3993530 into main Apr 14, 2022
@hariombalhara hariombalhara deleted the enhancements/embed branch April 14, 2022 02:47
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants