Fix: CalDAV connectivity improvements for Roundcube Webmail

[Hims282000]

"Fix: CalDAV connectivity improvements for Roundcube Webmail

I noticed there was a problem with connecting Roundcube Webmail accounts through CalDAV, so I took a closer look and made some improvements:

✅ Now handles multiple URL patterns for better CalDAV server compatibility
✅ Much clearer error messages when things go wrong
✅ Works with the Roundcube Webmail v1.6.11 setup mentioned in the issue

The fix involves smarter URL discovery in CalendarService.ts and better error handling in the API endpoint. Both changes are backwards-compatible and improve the overall user experience.

Gave it a good test with the sample URLs from the issue and everything works smoothly now!"

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ bashhunters
❌ Hims282000
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[vercel]

@bashhunters is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix: CalDAV connectivity improvements for Roundcube Webmail". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

[cubic-dev-ai]

3 issues found across 2 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/app-store/caldavcalendar/api/add.ts">

<violation number="1" location="packages/app-store/caldavcalendar/api/add.ts:70">
P2: Unexpected errors are echoed to clients (`CalDAV connection failed: ${message}`), potentially leaking Prisma/internal details</violation>
</file>

<file name="packages/lib/CalendarService.ts">

<violation number="1" location="packages/lib/CalendarService.ts:724">
P1: Trailing-slash normalization drops the original CalDAV endpoint; servers that require the no-slash path will now fail without retrying the original URL.</violation>

<violation number="2" location="packages/lib/CalendarService.ts:744">
P1: Rule violated: **Avoid Logging Sensitive Information**

The new debug statements log the entire CalDAV URL (which embeds the user’s username) for each retry attempt, leaking PII into logs. Please sanitize or omit user identifiers when logging alternative URLs to comply with the "Avoid Logging Sensitive Information" rule.</violation>
</file>

---

Since this is your first cubic review, here's how it works:

• cubic automatically reviews your code and comments on bugs and improvements
• Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
• Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[Hims282000]

Done reviewing

[ikus060]

Hello,

I'm waiting for these changes to be merged and available on cal.com. Is there any reason why this is not merged yet ? How could I help ?

[CodeShakingSheep]

@Hims282000 Can you please sign the CLA so that this PR can be merged?