fix(api-v2): correctly parse ISO timezone offsets when rescheduling bookings

[hemantmm]

closes: #28310

What does this PR do?

Remove the forced UTC parsing so Luxon respects the timezone information present in the ISO string.

• Fixes Internal Server Error when rescheduling a booking #28310
• Fixes CAL-7294

Mandatory Tasks (DO NOT REMOVE)

• I have self-reviewed the code (A decent size PR without self-review might be rejected).
• I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
• I confirm automated tests are in place that prove my fix is effective or that my feature works.

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts">

<violation number="1" location="apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts:699">
P2: Reschedule parsing is now environment-dependent for ISO strings without an explicit offset/zone. `@IsDateString()` allows offset-less ISO, and Luxon defaults to the server’s local zone when no offset is provided, so removing `{ zone: "utc" }` can shift rescheduled times across environments before converting to the attendee’s zone.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[sahitya-chandra]

Please address Cubic comments

[Ryukemeister]

hey @hemantmm, I had a closer look at this issue and it looks like removing the UTC parsing is not the correct fix. we need start time in UTC for both create and rescheduling bookings, however we don't explicitely mention this in the reschedule endpoint docs. if you have a look at the create a booking endpoint docs here we have this

The start needs to be in UTC aka if the timezone is GMT+2 in Rome and meeting should start at 11, then UTC time should have hours 09:00 aka without time zone.

the behaviour should be consistent for reschedule endpoint as well. so the real issue isn't the code — it's that the reschedule docs are missing the "in UTC timezone" requirement. The fix should be updating the reschedule endpoint's start field description to match create's: "Start time in ISO 8601 format in UTC timezone", and keeping { zone: "utc" } as-is.

stale

[github-actions]

This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active.

[sahitya-chandra]

CI checks failed can you fix it

[hemantmm]

Will try to fix it.

[emrysal]

Thank you for this docs change, much appreciated.