Allow scrolling when the dialog exceeds screen height#3850
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
emrysal
commented
Aug 14, 2022
| /> | ||
|
|
||
| <DialogContent className="overflow-y-auto"> | ||
| <DialogContent> |
Contributor
Author
There was a problem hiding this comment.
This didn't work before; but it did break the new scroll behaviour so for this reason I've edited this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently when we have a screen height that is not enough to for the dialog to fully display, there is no scroll behaviour. This introduces that, it has a padding of
py-4to maintain a little offset from the top.Main difference - overflow now wraps content, rather than them being separated.