Skip to content

Static images through webpack copy#3986

Merged
zomars merged 2 commits intomainfrom
feature/copy-app-store-static
Aug 26, 2022
Merged

Static images through webpack copy#3986
zomars merged 2 commits intomainfrom
feature/copy-app-store-static

Conversation

@emrysal
Copy link
Copy Markdown
Contributor

@emrysal emrysal commented Aug 26, 2022

Fixes an issue with [...static].jsx that seems to bundle all images up into one giant serverless function within Vercel.

Next 12.2 allows turning off next/image optimisation which I’ve done; optimisation is probably broken across the board on <Image /> for public/ assets but we’ve historically replaced with tags where this became a problem (see logo’s, app icons). We don’t really care about that feature anyway, not that kind of website.

Also rewrites don’t seem to work on assets, redirect worked no problem but a rewrite just didn’t.

@vercel
Copy link
Copy Markdown

vercel Bot commented Aug 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Aug 26, 2022 at 2:19PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
swagger ⬜️ Ignored (Inspect) Aug 26, 2022 at 2:19PM (UTC)

@emrysal emrysal requested a review from hariombalhara August 26, 2022 13:14
@emrysal
Copy link
Copy Markdown
Contributor Author

emrysal commented Aug 26, 2022

@alishaz-polymath could you verify whether this implementation supports Windows? 😅

@emrysal emrysal marked this pull request as ready for review August 26, 2022 14:08
@emrysal emrysal requested a review from a team August 26, 2022 14:08
@zomars zomars merged commit 19e9e00 into main Aug 26, 2022
@zomars zomars deleted the feature/copy-app-store-static branch August 26, 2022 16:31
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants