Merged
Conversation
added 2 commits
August 30, 2022 17:46
…nspect the `emailVerified` attribute as well.
…t and is causing confusion
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
agustif
approved these changes
Aug 30, 2022
Contributor
agustif
left a comment
agustif
left a comment
There was a problem hiding this comment.
LGTM, thank you for this @deepakprabhakara !
zomars
approved these changes
Aug 30, 2022
zomars
pushed a commit
that referenced
this pull request
Aug 30, 2022
* after first login the user is read from the db and hence we need to inspect the `emailVerified` attribute as well. * fixed mapping documentation for SAML, the current mapping is not right and is causing confusion
Udit-takkar
pushed a commit
to Udit-takkar/cal.com
that referenced
this pull request
Aug 30, 2022
* after first login the user is read from the db and hence we need to inspect the `emailVerified` attribute as well. * fixed mapping documentation for SAML, the current mapping is not right and is causing confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes SAML login which is broken due to a missing email_verified flag. Also contains a fix in SAML documentation for attribute mapping.
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist