Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alishaz-polymath
commented
Sep 2, 2022
Member
Author
alishaz-polymath
left a comment
alishaz-polymath
left a comment
There was a problem hiding this comment.
Self review added
Comment on lines
+166
to
+169
| /* React Select V2 */ | ||
| .cal-react-select-container .cal-react-select__control { | ||
| @apply bg-white min-h-[36px] h-[36px] text-sm leading-4 border-gray-300 hover:border-neutral-400 focus-within:ring-2 focus-within:ring-neutral-800 focus-within:border-0; | ||
| } |
Member
Author
There was a problem hiding this comment.
This would only come into the picture when we use V2 as the className prefix cal-react-select-container and cal-react-select is only added to the V2 select definition.
Comment on lines
+31
to
+35
| className={classNames( | ||
| "cal-react-select-container block h-[36px] w-full min-w-0 flex-1 rounded-md text-sm ", | ||
| className | ||
| )} | ||
| classNamePrefix="cal-react-select" |
Member
Author
There was a problem hiding this comment.
We add className prefixes cal-react-select-container and cal-react-select which allow us to target them and "apply" styling classes using tailwind
| styles={{ | ||
| option: (provided, state) => ({ | ||
| ...provided, | ||
| backgroundColor: state.isSelected ? "var(--brand-color)" : state.isFocused ? "#F3F4F6" : "", |
Member
Author
There was a problem hiding this comment.
For hover state of the options
PeerRich
approved these changes
Sep 2, 2022
Member
|
great work! @alishaz-polymath 👏 |
sean-brydon
previously requested changes
Sep 2, 2022
Member
|
Single NIT but looks awesome :) Nice job @alishaz-polymath |
alishaz-polymath
added
the
♻️ autoupdate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
V2 Select box changes
Fixes #4093
Loom
Environment: Staging(main branch) / Production
Type of change