Skip to content

#4110: Made vertical tabs in bookings and event types pages sticky.#4145

Merged
PeerRich merged 1 commit intocalcom:mainfrom
JeroenReumkens:feat/4110-sticky-vertical-tabs
Sep 4, 2022
Merged

#4110: Made vertical tabs in bookings and event types pages sticky.#4145
PeerRich merged 1 commit intocalcom:mainfrom
JeroenReumkens:feat/4110-sticky-vertical-tabs

Conversation

@JeroenReumkens
Copy link
Copy Markdown
Contributor

What does this PR do?

Made sidebars in booking and event types pages sticky. For this I added an extra prop sticky to the VerticalTabs component, so this sticky behaviour is opt-in, rather than the default.

Fixes #4110

Loom Video: https://www.loom.com/share/463d5c756ed24073beecfc05a4e22351

Environment: Staging(main branch)

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Verify that on both of the pages (bookings and event-types) the sticky bar behaviour is correct.
  • Verify that on both of the pages the sticky bar behaviour doesn't break anything on tablet and mobile (it shouldn't be used there, we use horizontal tabs instead of the vertical tabs there)

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 4, 2022

Someone is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@JeroenReumkens JeroenReumkens mentioned this pull request Sep 4, 2022
2 tasks
@JeroenReumkens
Copy link
Copy Markdown
Contributor Author

@Jaibles @PeerRich Slightly unrelated to this issue — but looking at the Loom video you notice that on the booking page the buttons to cancel/edit a booking aren't aligned properly. Same thing happens on main. Is this already a known issue? I couldn't find a bug for this. Thanks 🙏

@ciaranha ciaranha added this to the v.2.0 milestone Sep 4, 2022
@ciaranha
Copy link
Copy Markdown
Member

ciaranha commented Sep 4, 2022

@JeroenReumkens that looks great thank you!

i don't think it's a known issue.
I created and issue here. #4146

@vercel
Copy link
Copy Markdown

vercel bot commented Sep 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 4, 2022 at 2:10PM (UTC)

@PeerRich PeerRich enabled auto-merge (squash) September 4, 2022 14:04
Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Sticky internal sidebars

3 participants