#4110: Made vertical tabs in bookings and event types pages sticky.#4145
Merged
PeerRich merged 1 commit intocalcom:mainfrom Sep 4, 2022
Merged
Conversation
|
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
2 tasks
Contributor
Author
|
@Jaibles @PeerRich Slightly unrelated to this issue — but looking at the Loom video you notice that on the booking page the buttons to cancel/edit a booking aren't aligned properly. Same thing happens on main. Is this already a known issue? I couldn't find a bug for this. Thanks 🙏 |
Member
|
@JeroenReumkens that looks great thank you! i don't think it's a known issue. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Made sidebars in booking and event types pages sticky. For this I added an extra prop
stickyto theVerticalTabscomponent, so this sticky behaviour is opt-in, rather than the default.Fixes #4110
Loom Video: https://www.loom.com/share/463d5c756ed24073beecfc05a4e22351
Environment: Staging(main branch)
Type of change
How should this be tested?