Skip to content

fixed horizontal nav on mobile, hiding scrollbar#4176

Merged
emrysal merged 2 commits intomainfrom
4173-mobile-vertical-nav-should-cut-off-at-screen-not-at-component-level
Sep 5, 2022
Merged

fixed horizontal nav on mobile, hiding scrollbar#4176
emrysal merged 2 commits intomainfrom
4173-mobile-vertical-nav-should-cut-off-at-screen-not-at-component-level

Conversation

@PeerRich
Copy link
Copy Markdown
Member

@PeerRich PeerRich commented Sep 5, 2022

before
CleanShot 2022-09-05 at 15 00 17

after:
CleanShot 2022-09-05 at 15 19 36

closes #4173

@PeerRich PeerRich linked an issue Sep 5, 2022 that may be closed by this pull request
@PeerRich PeerRich requested a review from sean-brydon September 5, 2022 13:19
@vercel
Copy link
Copy Markdown

vercel bot commented Sep 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 5, 2022 at 2:48PM (UTC)

Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - smart :)

@emrysal emrysal enabled auto-merge (squash) September 5, 2022 14:46
@emrysal emrysal merged commit d0aaa4d into main Sep 5, 2022
@emrysal emrysal deleted the 4173-mobile-vertical-nav-should-cut-off-at-screen-not-at-component-level branch September 5, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

mobile: vertical nav should cut off at screen, not at component level

3 participants