Skip to content

Rounded divider + Fixing button group#4233

Merged
PeerRich merged 4 commits intomainfrom
4181-routing-form-detail
Sep 7, 2022
Merged

Rounded divider + Fixing button group#4233
PeerRich merged 4 commits intomainfrom
4181-routing-form-detail

Conversation

@sean-brydon
Copy link
Copy Markdown
Member

What does this PR do?

Fixes button group and adds rounded divider. I will take no credit for the button group fix (he massively gave inspiration with this approach) - Thank you https://twitter.com/malfaitrobin

Before:
CleanShot 2022-09-07 at 11 40 37@2x

After:
CleanShot 2022-09-07 at 11 39 34@2x

Fixes #4181

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 7, 2022 at 10:59AM (UTC)

Copy link
Copy Markdown
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

Comment thread packages/ui/v2/core/ButtonGroup.tsx
@PeerRich PeerRich enabled auto-merge (squash) September 7, 2022 10:56
@PeerRich PeerRich added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Sep 7, 2022
@PeerRich PeerRich added this to the Quick Wins milestone Sep 7, 2022
@PeerRich PeerRich added the ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work label Sep 7, 2022
@PeerRich PeerRich modified the milestones: Quick Wins, v.2.0 Sep 7, 2022
@PeerRich PeerRich merged commit 00f5ba2 into main Sep 7, 2022
@PeerRich PeerRich deleted the 4181-routing-form-detail branch September 7, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

/routing-form-detail - header actions - combined button component has double border

2 participants