Removes dynamic dimensions for V2 Skeletons in favor of classnames#4263
Merged
Removes dynamic dimensions for V2 Skeletons in favor of classnames#4263
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zomars
changed the title
sean-brydon
approved these changes
Sep 9, 2022
Member
sean-brydon
left a comment
sean-brydon
left a comment
There was a problem hiding this comment.
LGTM - whoever wrote them dynamic classNames should be shot 😅 (It was me)
PeerRich
reviewed
Sep 9, 2022
| width: "2" | "3" | "4" | "5" | "6" | "8" | "12"; | ||
| height: "2" | "3" | "4" | "5" | "6" | "8" | "12"; | ||
| // Limit this cause we don't use avatars bigger than this | ||
| /** @deprecated @see https://tailwindcss.com/docs/content-configuration#dynamic-class-names */ |
Member
There was a problem hiding this comment.
why show deprecated when we just replace it everywhere?
Contributor
Author
There was a problem hiding this comment.
Not worth the effort now as we will remove it post v2
PeerRich
approved these changes
Sep 9, 2022
Member
PeerRich
left a comment
PeerRich
left a comment
There was a problem hiding this comment.
does it change anything visually? or just a refactor cleanup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
widthandheightprops from V2 SkeletonsFor more context on this decision: https://tailwindcss.com/docs/content-configuration#dynamic-class-names
Type of change