Add rounded-none to combined buttons by default#4330
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sean-brydon
commented
Sep 9, 2022
| "flex", | ||
| !combined | ||
| ? "space-x-2" | ||
| : "[&_button]:border-l-0 [&>*:first-child]:rounded-l-md [&>*:first-child]:border-l [&_a]:border-l-0 [&>*:last-child]:rounded-r-md", |
Member
Author
There was a problem hiding this comment.
Formatting confused this a bit - adds all button/anchor Childs to have rounded-none by default (This overrides out button component to achieve the look we want :) )
Member
|
can you also add all instances where this is obsolete and remove it? |
PeerRich
deleted the
4329-find-a-way-to-remove-combined-prop-from-button
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was easier than I thought ...
Before
After:
Results are exactly the same
