a ton of mobile improvements to save space#4336
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…aking-columns-smaller
…ns-smaller' of https://github.com/calcom/cal.com into 4334-booking-save-more-horizontal-space-by-making-columns-smaller
…aking-columns-smaller
…ns-smaller' of https://github.com/calcom/cal.com into 4334-booking-save-more-horizontal-space-by-making-columns-smaller
zomars
reviewed
Sep 9, 2022
emrysal
reviewed
Sep 9, 2022
Massive nit, lol.
emrysal
previously requested changes
Sep 9, 2022
Contributor
There was a problem hiding this comment.
Definitely a unit test issue, the clarity could be improved though.
TypeError: window.getEmbedTheme is not a function
372 | if (isBrowser) {
373 | const url = new URL(document.URL);
> 374 | embedStore.theme = (window.getEmbedTheme() || "auto") as UiConfig["theme"];
…aking-columns-smaller
emrysal
deleted the
4334-booking-save-more-horizontal-space-by-making-columns-smaller
branch
joeauyeung
pushed a commit
that referenced
this pull request
Sep 9, 2022
* made /booking more responsive friendly * hiding headline and description on mobile, moving CTA to bottom right fixed on mobile * more padding on full screen mode on iPhone * nit fixes to wipemycal * nit fixes to wipemycal * lint fix * Update apps/web/styles/globals.css Massive nit, lol. Co-authored-by: Alex van Andel <me@alexvanandel.com>
Member
Author
|
thank you for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/bookings before:
/bookings after:
demo:
https://user-images.githubusercontent.com/8019099/189352382-3b890ca2-89e3-46b7-8f2f-fbe38d89132c.mp4
recorded on iPhone 12 Mini:
RPReplay_Final1662728078.mp4