fix: Fixed password peek alignment which wasnot correct in all places.#4582
Merged
Merged
Conversation
|
@JeroenReumkens is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
PeerRich
added a commit
that referenced
this pull request
Sep 18, 2022
* Fix typeform how-to-use page (#4567) * Hotfix: Add back copy Typeform redirect url link and update screenshot (#4569) * Add back copy Typeform redirect url link and update screenshot * Delete unused files * fixed button group in /teams (#4573) * fixed button group in /teamas * nit * added more app store screenshots (#4564) * added screenshots * nit * fixed #4574 * fix: Fixed password peek alignment which wasnot correct in all places. (#4582) Co-authored-by: Hariom Balhara <hariombalhara@gmail.com> Co-authored-by: Jeroen Reumkens <hello@jeroenreumkens.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed that a recent change broke the alignment of the password peek icon on the login page. I did a small tweak to the password field component just now to fix it in both instances. The fix removes any margin applied to the password input field. I don't think we need to have them specifically on the input field (you'd rather add them on the wrapping components instead of giving components that can be used in a lot of places a margin), but if we ever want to add them back I'd suggest adding them to the place where I've now put
mb-0.Old broken situation
New situation
Environment: Staging(main branch)
Type of change
How should this be tested?