Skip to content

fix padding#4673

Merged
PeerRich merged 4 commits intocalcom:mainfrom
gitstart:CAL-304
Sep 28, 2022
Merged

fix padding#4673
PeerRich merged 4 commits intocalcom:mainfrom
gitstart:CAL-304

Conversation

@gitstart
Copy link
Copy Markdown
Contributor

@gitstart gitstart commented Sep 22, 2022

What does this PR do?

Previously, the 'Add variable' button was misaligned with the rest of the div, in addition to exceeding the Textarea. Now the button alignment is fixed.

Fixes #4461

Demo

Old Version:
image

Updated Version:
Screen Shot 2022-09-22 at 10 25 02 PM

https://www.loom.com/share/cbcc7c4a60e14534afb973e6fe6dee4b

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Co-authored-by: gitstart <gitstart@gitstart.com>
Co-authored-by: gitstart <gitstart@users.noreply.github.com>
Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev>
Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com>
Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com>
Co-authored-by: Grace Nshokano <grace.devolop@gmail.com>
Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com>
Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 22, 2022

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CarinaWolli CarinaWolli self-requested a review September 28, 2022 09:49
Copy link
Copy Markdown
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution 🙏

@CarinaWolli CarinaWolli enabled auto-merge (squash) September 28, 2022 09:50
@PeerRich PeerRich disabled auto-merge September 28, 2022 21:01
@PeerRich PeerRich changed the title /workflows /detail-view - Add variable button hover alignment is off fix padding Sep 28, 2022
@PeerRich PeerRich closed this Sep 28, 2022
@PeerRich PeerRich reopened this Sep 28, 2022
@PeerRich PeerRich merged commit be15aff into calcom:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/workflows /detail-view - Add variable button hover alignment is off

3 participants