Skip to content

Fixing wrapping of buttons in appstore#4704

Merged
leog merged 3 commits into
mainfrom
fix/app-store-buttons-wrap
Sep 26, 2022
Merged

Fixing wrapping of buttons in appstore#4704
leog merged 3 commits into
mainfrom
fix/app-store-buttons-wrap

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Sep 25, 2022

What does this PR do?

Buttons in App Store page were wrapping when no space left. Now we only rely in the breakpoint which already managed the app cards and how they look.

Fixes #4604.

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

See video in #4604 to check that it doesn't look like that anymore.

@leog leog added this to the v.2.1 milestone Sep 25, 2022
@leog leog requested a review from a team September 25, 2022 13:52
@leog leog self-assigned this Sep 25, 2022
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 26, 2022 at 0:44AM (UTC)

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups too :)

@leog leog merged commit 9ddbaf0 into main Sep 26, 2022
@leog leog deleted the fix/app-store-buttons-wrap branch September 26, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

/apps: buttons break on medium layout

2 participants