feat: add optimistic updates for deleting and changing hidden status of event types.#4721
Merged
zomars merged 7 commits intocalcom:mainfrom Oct 18, 2022
Merged
Conversation
|
@G3root is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zomars
approved these changes
Oct 18, 2022
Contributor
zomars
left a comment
zomars
left a comment
There was a problem hiding this comment.
I'm pretty sure we can improve the legibility a little bit by extracting the update state logic into a function. But it works for now.
# Conflicts: # apps/web/pages/v2/event-types/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://www.loom.com/share/8315c31c1c6840338ec918929fc3194c
Environment: Staging(main branch) / Production
Type of change