Skip to content

public page: border and padding#4730

Merged
PeerRich merged 5 commits intocalcom:mainfrom
gitstart:CAL-323
Sep 29, 2022
Merged

public page: border and padding#4730
PeerRich merged 5 commits intocalcom:mainfrom
gitstart:CAL-323

Conversation

@gitstart
Copy link
Copy Markdown
Contributor

Fixes #4671

What this PR does / why we need it:

This PR fixes: adding padding bottom in date picker; changed top and bottom borders color and removed border in the modal, all when its mobile screen.

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

Demo

  • More padding bottom on mobile ->

4671 - PADDING ON MOBILE


  • Wrong border color ->

4671 - WRONG BORDER COLOR


  • Remove border on mobile ->

4671 - REMOVE BORDER ON MOBILE

Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev>
Co-authored-by: gitstart <gitstart@users.noreply.github.com>
Co-authored-by: Klinger Matheus <50892465+KlingerMatheus@users.noreply.github.com>
Co-authored-by: Klinger Matheus <klinger.matheus@gitstart.dev>
Co-authored-by: Grace Nshokano <grace.devolop@gmail.com>
Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com>
Co-authored-by: Olusanya Timothy <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 28, 2022

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@gitstart
Copy link
Copy Markdown
Contributor Author

Hi @PeerRich! Kindly review the PR

<div
className={classNames(
"main overflow-hidden",
isEmbed ? "" : "border border-gray-200",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hariombalhara is this save to be deleted?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah should be okay as embed didn't have this earlier and now it's being removed from here.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Sep 28, 2022 at 6:15PM (UTC)

@PeerRich PeerRich merged commit 246c90c into calcom:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

public page: border and padding

3 participants