Fix destination calendar overflow on installed and move DestinationCalendarSelector to feature package#4778
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@joeauyeung That looks a bit off, as the combobox now doesn't include details of the calendar (to avoid a long ID overflowing the UI), it now looks too big for its content. Maybe a better solution would be to truncate that ID, as the idea is to provide a way to identify which calendar provider was selected aside from the name. Also, the long ID comes from a CalDav calendar right? When a Google Calendar is selected, the Google email associated to the Google Calendar should show up as the ID of that Google Calendar. The goal here is, as you may have multiple Google Calendars and in the case you have identical calendars in them, you couldn't know which was selected as destination. |
|
@leog what if we render the integration headers that are present when choosing a destination calendar? Here's a Loom with my thoughts |
Very well thought, I like it 👍 I wonder if we can improve that lag when loading the name to make it perfect. Anyway, I think it works, we could ask @Jaibles just to confirm. |
joeauyeung
added
the
🎨 needs design
|
@joeauyeung @leog this looks good to me in the Loom! Would it be awkward/weird to remove the "calendar" in these particular instances just to shorten this? I know technically it's correct to leave it in, to match the app name but it does really make the labelling longer and it's obvious here it's a calendar. |
joeauyeung
removed
the
🎨 needs design
leog
left a comment
leog
left a comment
There was a problem hiding this comment.
Looks good to me! Nice work Joe
| name: "Outlook Calendar", | ||
| description: _package.description, | ||
| type: "office365_calendar", | ||
| title: "Office 365 / Outlook.com Calendar", | ||
| title: "Outlook Calendar", |
There was a problem hiding this comment.
This should be another PR but I'll allow it
|
We do have some type-check errors tho. |
…/calcom/cal.com into hotfix/install-calendar-overflow
…lendarSelector to feature package (calcom#4778) * Standardize destination calendar selector * Move DestinationCalendarSelector to feature package * Render integration name * Add custom components to label and selected * Render destinationCalendar on page load * Change name to just Outlook * Small fixes * Merge branch 'main' into hotfix/install-calendar-overflow * Merge branch 'main' into hotfix/install-calendar-overflow * Fix type errors * Fix type errors * Update apps/web/pages/settings/my-account/calendars.tsx * More type fixes Co-authored-by: Omar López <zomars@me.com>
…lendarSelector to feature package (calcom#4778) * Standardize destination calendar selector * Move DestinationCalendarSelector to feature package * Render integration name * Add custom components to label and selected * Render destinationCalendar on page load * Change name to just Outlook * Small fixes * Merge branch 'main' into hotfix/install-calendar-overflow * Merge branch 'main' into hotfix/install-calendar-overflow * Fix type errors * Fix type errors * Update apps/web/pages/settings/my-account/calendars.tsx * More type fixes Co-authored-by: Omar López <zomars@me.com>
4 participants
What does this PR do?
This PR fixes the destination calendar overflowing when the ID was too long. I have also moved the DestinationCalendarSelector to the feature/calendar package.
Before
After
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist