Improve password peek positioning accross app and website.#4810
Merged
Improve password peek positioning accross app and website.#4810
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leog
approved these changes
Oct 3, 2022
Contributor
leog
left a comment
leog
left a comment
There was a problem hiding this comment.
Looks great, good job @JeroenReumkens 👍
emrysal
added
♻️ autoupdate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves general positioning of the password peek tooltip. Redid the styling a bit so we can use the addonSuffix, which ensures that the element is positioned within the input wrapper, making absolute positioning a lot easier :)
This issue mainly fixes the positioning on
cal.com/signup, but also impacts the password elements on eg/settings/security/passwordand/auth/setup. Tested all 3 of these, see screenshots. Added @leog as a reviewer since he recently also fixed the auth/setup page, and want to inform him of this change as well :)Proof that it's fixed:
Settings page
/signup page
Auth/setup page
Environment: Staging(main branch)
Type of change
How should this be tested?