#4252 Use vercel og to generate og images for meetings and apps.#4943
Merged
#4252 Use vercel og to generate og images for meetings and apps.#4943
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JeroenReumkens
commented
Oct 18, 2022
| @@ -1,4 +1,4 @@ | |||
| <svg id="svg" version="1.1" xmlns="http://www.w3.org/2000/svg" width="1.25em" height="1.25em" viewBox="0, 0, 400,400"> | |||
| <svg id="svg" xmlns="http://www.w3.org/2000/svg" width="40" height="40" viewBox="0,0,400,400"> | |||
Contributor
Author
There was a problem hiding this comment.
Had to tweak a few SVG's because otherwise vercel/og wouldn't render them.
JeroenReumkens
commented
Oct 18, 2022
| import { NextSeo, NextSeoProps } from "next-seo"; | ||
| import React from "react"; | ||
|
|
||
| import { constructAppImage, constructMeetingImage } from "@calcom/lib/OgImages"; |
Contributor
Author
There was a problem hiding this comment.
The v2 of head-seo doesn't seem to be used at all yet, but I did update it since chance is big this one remains and the other gets deleted :)
JeroenReumkens
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generates OG images for apps and meetings with the new Vercel OG.
Pages it generates images for:
/apps/.../[user]/[user]/[type]/team/[slug]/team/[slug]/[type]Small tweaks needed after a check in prod
It seems that for the avatars there's quite a few ways in which they might be used; users do/don't have avatars, teams do/don't, and sometimes it seems to return an avatar while other times it could return a base64 string (which @zomars I believe is removing soon). So I can imagine there's some edge cases that I couldn't find locally (image upload locally also doesn't work on my end), so I think we also have to test this heavily in production, and see which cases aren't handled yet. If an image breaks, it's the api route that breaks for that one image, so the image simply won't load. It should not impact the page itself. Curious what others think about this 😄
Preview images
Single user
Collection, lots of people and long title
Team of 2 (collection)
Round robin
Dynamic collective
App
Fixes #4252
Environment: Staging(main branch)
Type of change
How should this be tested?
og:image