Add/Edit location dialog: "can't find the right video app? visit our app store" by gitstart · Pull Request #4990 · calcom/cal.diy

gitstart · 2022-10-13T15:46:18Z

What does this PR do?

Add/Edit location dialog: "can't find the right video app? visit our app store"

Fixes #4298

Loom: https://www.loom.com/share/bb2ad8e9853941abaabeba4a4d2985c4

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't performed a self-review of my own code and corrected any misspellings
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my PR needs changes to the documentation
I haven't checked if my changes generate no new warnings
I haven't added tests that prove my fix is effective or that my feature works
I haven't checked if new and existing unit tests pass locally with my changes

vercel · 2022-10-13T15:46:24Z

@gitstart is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

hariombalhara

See the comment

gitstart · 2022-10-20T10:33:54Z

@hariombalhara @Jaibles required changes has been made, please review
https://www.loom.com/share/feee45a1ab1d49d0953d2b41e081f1f9

ciaranha · 2022-10-20T11:46:42Z

@gitstart looks good thank you 🙏

vercel · 2022-10-20T12:19:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
cal	✅ Ready (Inspect)	Visit Preview	Oct 21, 2022 at 5:45PM (UTC)

hariombalhara · 2022-10-20T12:23:09Z

That's how I see it now.

hariombalhara

See the last comment

…app store" Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Matheus Benini Ferreira <88898100+MatheusBeniniF@users.noreply.github.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com> Co-authored-by: Matheus Benini <matheus_benini@hotmail.com> Co-authored-by: Murilo Amaral <87545137+MuriloAmarals@users.noreply.github.com> Co-authored-by: Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Rafael <rafael.toledo@engenharia.ufjf.br> Co-authored-by: Grace Nshokano <grace.devolop@gmail.com> Co-authored-by: MuriloAmarals <muralha2000@gmail.com> Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com> Co-authored-by: Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev> Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com> Co-authored-by: C000Ldude <coolmagnas@gmail.com> Co-authored-by: Klinger Matheus <50892465+KlingerMatheus@users.noreply.github.com> Co-authored-by: Eman <emmanuelgatwech@gmail.com>

gitstart · 2022-10-20T12:45:25Z

@hariombalhara It should be fixed now, please take a look

…app store" (calcom#4990) Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev> Co-authored-by: Matheus Benini Ferreira <88898100+MatheusBeniniF@users.noreply.github.com> Co-authored-by: gitstart <gitstart@users.noreply.github.com> Co-authored-by: gitstart <gitstart@gitstart.com> Co-authored-by: Rafael Toledo <87545086+Toledodev@users.noreply.github.com> Co-authored-by: Matheus Benini <matheus_benini@hotmail.com> Co-authored-by: Murilo Amaral <87545137+MuriloAmarals@users.noreply.github.com> Co-authored-by: Rubens Rafael <70234898+RubensRafael@users.noreply.github.com> Co-authored-by: Thiago Nascimbeni <tnascimbeni@gmail.com> Co-authored-by: Rafael <rafael.toledo@engenharia.ufjf.br> Co-authored-by: Grace Nshokano <grace.devolop@gmail.com> Co-authored-by: MuriloAmarals <muralha2000@gmail.com> Co-authored-by: Matheus Muniz <matheusmuniz100@hotmail.com> Co-authored-by: Júlio Piubello da Silva Cabral <julio.piubello@gitstart.dev> Co-authored-by: Matheus Muniz <87545749+matheusmuniz03@users.noreply.github.com> Co-authored-by: C000Ldude <coolmagnas@gmail.com> Co-authored-by: Klinger Matheus <50892465+KlingerMatheus@users.noreply.github.com> Co-authored-by: Eman <emmanuelgatwech@gmail.com>

MatheusBeniniF mentioned this pull request Oct 13, 2022

[CAL-101] Add/Edit location dialog: "can't find the right video app? visit our app store" #4298

Closed

sauravgurhale reviewed Oct 13, 2022

View reviewed changes

Comment thread apps/web/components/v2/eventtype/EditLocationDialog.tsx Outdated

gitstart force-pushed the CAL-383 branch from 4d894bc to f9ae622 Compare October 17, 2022 07:21

gitstart requested a review from sauravgurhale October 17, 2022 07:24

gitstart force-pushed the CAL-383 branch from f9ae622 to 47b8fe7 Compare October 17, 2022 11:27

hariombalhara requested changes Oct 18, 2022

View reviewed changes

Comment thread apps/web/components/ui/LinkText.tsx

Comment thread apps/web/components/v2/eventtype/EditLocationDialog.tsx Outdated

gitstart requested review from hariombalhara and removed request for sauravgurhale October 20, 2022 07:22

gitstart force-pushed the CAL-383 branch from 01db5cd to e836521 Compare October 20, 2022 10:30

hariombalhara requested changes Oct 20, 2022

View reviewed changes

vercel Bot had a problem deploying to Preview October 20, 2022 12:25 Failure

gitstart force-pushed the CAL-383 branch from e836521 to c49edc8 Compare October 20, 2022 12:43

gitstart requested a review from hariombalhara October 20, 2022 12:45

Merge branch 'main' into CAL-383

4081054

hariombalhara approved these changes Oct 21, 2022

View reviewed changes

vercel Bot deployed to Preview October 21, 2022 17:45 View deployment

PeerRich merged commit b7892b1 into calcom:main Oct 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add/Edit location dialog: "can't find the right video app? visit our app store"#4990

Add/Edit location dialog: "can't find the right video app? visit our app store"#4990
PeerRich merged 2 commits intocalcom:mainfrom
gitstart:CAL-383

gitstart commented Oct 13, 2022

Uh oh!

vercel Bot commented Oct 13, 2022

Uh oh!

Uh oh!

hariombalhara left a comment

Uh oh!

Uh oh!

Uh oh!

gitstart commented Oct 20, 2022

Uh oh!

ciaranha commented Oct 20, 2022

Uh oh!

vercel Bot commented Oct 20, 2022 •

edited

Loading

Uh oh!

hariombalhara commented Oct 20, 2022

Uh oh!

hariombalhara left a comment

Uh oh!

gitstart commented Oct 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gitstart commented Oct 13, 2022

What does this PR do?

Type of change

Checklist

Uh oh!

vercel Bot commented Oct 13, 2022

Uh oh!

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gitstart commented Oct 20, 2022

Uh oh!

ciaranha commented Oct 20, 2022

Uh oh!

vercel Bot commented Oct 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hariombalhara commented Oct 20, 2022

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

gitstart commented Oct 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel Bot commented Oct 20, 2022 •

edited

Loading