Stop long urls from overflowing on booking page.#5240
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Tested on mobile viewport? |
Contributor
Author
|
@harshsinghatz Jep!
On smaller screens it overflows the same: |
pumfleet
approved these changes
Oct 27, 2022
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents long urls (or other very long texts for that matter) from overflowing on the public booking page. It will only break long words if they're longer than one sentence.
It's not the most beautiful thing, but for edge cases this works and is way better than the overflowing. Probably down the line we can add the HTML editor @CarinaWolli is working on here as well, and give people to option to add real anchors?
Before
After
Environment: Staging(main branch)
Type of change
How should this be tested?