Skip to content

Improving recurring info in bookings#5253

Merged
emrysal merged 8 commits intomainfrom
fix/recurring-info-improvement
Nov 4, 2022
Merged

Improving recurring info in bookings#5253
emrysal merged 8 commits intomainfrom
fix/recurring-info-improvement

Conversation

@leog
Copy link
Copy Markdown
Contributor

@leog leog commented Oct 27, 2022

What does this PR do?

Recurring event in bookings was not showing the right information when it came to the dates tooltip.

This PR introduces fixes and additional visualization for cancelled instances:

Pending:

  • @emrysal I need your help about DST, look at the example screenshot above, 8:10pm converts into 7:10pm at certain point

Fixes #5231

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Book a recurring event and cancel one instance, and reschedule another instance. New date/time for rescheduled and cancelled instances should be shown correctly.

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Nov 4, 2022 at 4:35PM (UTC)

@leog
Copy link
Copy Markdown
Contributor Author

leog commented Nov 4, 2022

@emrysal reminder about this PR waiting for your love!

@emrysal emrysal marked this pull request as ready for review November 4, 2022 16:04
@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Nov 4, 2022

@leog DST issue was not actually due to your PR but due to recurring bookings being booked in the at the wrong time entirely. With the fixes that have gone into main now, this can be merged too 👍

Copy link
Copy Markdown
Member

@sean-brydon sean-brydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Nice job @emrysal and @leog

DST is always a pain in the ass - Love the UI for the tooltip too :)

@emrysal emrysal merged commit 25e3e31 into main Nov 4, 2022
@emrysal emrysal deleted the fix/recurring-info-improvement branch November 4, 2022 16:43
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
* Improving recurring info in bookings

* Adding fixes to success page, it was invalid on custom tz

* Remove dead code

Co-authored-by: Alex van Andel <me@alexvanandel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-261] Events Remaining display wrong time of remaining events on event reschedule

3 participants