Skip to content

Add attendee's email as a dynamic text variable#5258

Merged
CarinaWolli merged 2 commits intomainfrom
fix/attendee-email-workflow-variable
Oct 28, 2022
Merged

Add attendee's email as a dynamic text variable#5258
CarinaWolli merged 2 commits intomainfrom
fix/attendee-email-workflow-variable

Conversation

@CarinaWolli
Copy link
Copy Markdown
Member

What does this PR do?

Add attendee's email to dynamic text variables for custom workflow templates. Also add some small design improvements for the AddVariablesDropdown .

Screenshot 2022-10-28 at 09 36 04

Fixes #5223

Environment: Staging(main branch)

@CarinaWolli CarinaWolli requested a review from a team October 28, 2022 07:38
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 9:52AM (UTC)

Copy link
Copy Markdown
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good codewise.
@CarinaWolli What's the best way to test workflows on local considering workflow emails don't work locally.

@CarinaWolli
Copy link
Copy Markdown
Member Author

@CarinaWolli What's the best way to test workflows on local considering workflow emails don't work locally.

I have set up a free SendGrid account so I can test workflow emails locally. But otherwise, in this case, you could just console log the email content (emailReminderManager.ts) and check if it looks as expected

@CarinaWolli CarinaWolli enabled auto-merge (squash) October 28, 2022 09:42
@CarinaWolli CarinaWolli merged commit 9f362db into main Oct 28, 2022
@CarinaWolli CarinaWolli deleted the fix/attendee-email-workflow-variable branch October 28, 2022 09:53
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
Co-authored-by: CarinaWolli <wollencarina@gmail.com>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-268] enable a corresponding variable for all input fields (add variable for email)

3 participants