Skip to content

Allow og image api in robots.txt#5283

Merged
PeerRich merged 2 commits intomainfrom
fix/allow-og-image-api-in-robots
Oct 31, 2022
Merged

Allow og image api in robots.txt#5283
PeerRich merged 2 commits intomainfrom
fix/allow-og-image-api-in-robots

Conversation

@JeroenReumkens
Copy link
Copy Markdown
Contributor

@JeroenReumkens JeroenReumkens commented Oct 31, 2022

What does this PR do?

Allows OG image api in robots.txt so Twitter can access it to render images.

Before Twitter would error like so:

CleanShot 2022-10-31 at 08 31 58@2x

Results on test env:

CleanShot 2022-10-31 at 10 34 00@2x

CleanShot 2022-10-31 at 10 34 42@2x

CleanShot 2022-10-31 at 10 35 14@2x

CleanShot 2022-10-31 at 10 39 47@2x

As for Twitter; It seems that the dev preview tool doesn't show previews anymore, only validates (multiple github issues etc around. Next to that, Twitter.com DOES have some aggressive caching ;)

CleanShot 2022-10-31 at 10 40 50@2x

Environment: Staging(main branch)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 9:15AM (UTC)

@PeerRich PeerRich merged commit 5dc5ead into main Oct 31, 2022
@PeerRich PeerRich deleted the fix/allow-og-image-api-in-robots branch October 31, 2022 09:48
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
Co-authored-by: Peer Richelsen <peeroke@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants