Skip to content

Fix: EventType Ordering listing#5291

Merged
emrysal merged 1 commit intomainfrom
fix/eventtype-reordering
Oct 31, 2022
Merged

Fix: EventType Ordering listing#5291
emrysal merged 1 commit intomainfrom
fix/eventtype-reordering

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

@hariombalhara hariombalhara commented Oct 31, 2022

Bug Introduced here #4727 (files)

Fixes #5255

I had expected TS to complain while doing the cleanup but it didn't because orderBy is not completely TS safe

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 0:04AM (UTC)

@hariombalhara hariombalhara changed the title Ensure position is present Fix: EventType Ordering listing Oct 31, 2022
@hariombalhara hariombalhara requested a review from emrysal October 31, 2022 12:02
Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@emrysal emrysal enabled auto-merge (squash) October 31, 2022 12:11
@emrysal emrysal merged commit dd9d328 into main Oct 31, 2022
@emrysal emrysal deleted the fix/eventtype-reordering branch October 31, 2022 12:13
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-273] BUG: Reordering event types not working

3 participants