Fixes recurring hard crash in two places to ensure rrule gets valid p…#5350
Merged
Fixes recurring hard crash in two places to ensure rrule gets valid p…#5350
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alannnc
approved these changes
Nov 3, 2022
Contributor
alannnc
left a comment
alannnc
left a comment
There was a problem hiding this comment.
Code looks good, couldn't replicate the error tho
haffla
pushed a commit
to tourlane/cal.com
that referenced
this pull request
Nov 22, 2022
…arameters (calcom#5350) Co-authored-by: alannnc <alannnc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecurringInfo could be null in some situations when the event type hasn't always been a recurring event, this caused undefined values passed to rrule - triggering an infinite loop in the library.