Skip to content

Fix viewer.me avatar size#5392

Merged
emrysal merged 2 commits intomainfrom
fix/viewer.me/avatar
Nov 5, 2022
Merged

Fix viewer.me avatar size#5392
emrysal merged 2 commits intomainfrom
fix/viewer.me/avatar

Conversation

@hariombalhara
Copy link
Copy Markdown
Member

What does this PR do?

Fixes #5299 (comment)

Environment: Production

Type of change

  • Improvement (non-breaking change which fixes an issue)

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Nov 5, 2022 at 5:37PM (UTC)

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Nov 5, 2022

  • The avatar field in the viewer object is changed from a string to an expression.
  • The value of the avatar field is now ${CAL_URL}/${user.username}/avatar.png instead of just user's username (e.g., "johndoe").

Copy link
Copy Markdown
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@emrysal
Copy link
Copy Markdown
Contributor

emrysal commented Nov 5, 2022

Added SSRConfig to the NextJsAppProps typing to workaround a broken type in next-i18next - will be fixed v13.0.0 but until then.. keeping an eye on i18next/next-i18next#1944

@emrysal emrysal merged commit a8c4a9c into main Nov 5, 2022
@emrysal emrysal deleted the fix/viewer.me/avatar branch November 5, 2022 18:00
emrysal added a commit that referenced this pull request Nov 10, 2022
* Fix viewer.me avatar size

* Fix for i18n-next typecheck

Co-authored-by: Alex van Andel <me@alexvanandel.com>
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
* Fix viewer.me avatar size

* Fix for i18n-next typecheck

Co-authored-by: Alex van Andel <me@alexvanandel.com>
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants