Skip to content

Check for existence of NEXTAUTH_URL before overwriting#5419

Merged
pumfleet merged 2 commits intocalcom:mainfrom
krumware:patch-2
Nov 8, 2022
Merged

Check for existence of NEXTAUTH_URL before overwriting#5419
pumfleet merged 2 commits intocalcom:mainfrom
krumware:patch-2

Conversation

@krumware
Copy link
Copy Markdown
Contributor

@krumware krumware commented Nov 8, 2022

What does this PR do?

This allows NEXTAUTH_URL to be configurable to a different domain than NEXT_PUBLIC_WEBAPP_URL

Fixes # (issue)

closes #5418

Environment: Staging(main branch) / Production

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 8, 2022

@krumware is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Nov 8, 2022

  • The if statement was changed to an if/else
  • If the NEXTAUTH_URL is not set, then it will use NEXT_PUBLIC_WEBAPP_URL + "/api/auth" as a fallback

@krumware
Copy link
Copy Markdown
Contributor Author

krumware commented Nov 8, 2022

@baileypumfleet

@pumfleet pumfleet merged commit cde02e1 into calcom:main Nov 8, 2022
emrysal pushed a commit that referenced this pull request Nov 10, 2022
* check for existence of NEXTAUTH_URL before overwriting

* add comment
haffla pushed a commit to tourlane/cal.com that referenced this pull request Nov 22, 2022
* check for existence of NEXTAUTH_URL before overwriting

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(next-auth) Service unable to call back to itself if address doesn't match public URL

2 participants