Skip to content

fix: use Intl to format month name#5449

Merged
kodiakhq[bot] merged 1 commit into
mainfrom
fix/format-calendar-month
Nov 9, 2022
Merged

fix: use Intl to format month name#5449
kodiakhq[bot] merged 1 commit into
mainfrom
fix/format-calendar-month

Conversation

@Udit-takkar
Copy link
Copy Markdown
Contributor

Fixes: #5442

Screenshot 2022-11-10 at 12 10 22 AM

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 6:47PM (UTC)

@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Nov 9, 2022

  • Added useLocale hook to import
  • Changed the month format from browsingDate.format("MMMM") to new Intl.DateTimeFormat(i18n.language, {month: "long"}).format(new Date(browsingDate))

Copy link
Copy Markdown
Contributor

@JeroenReumkens JeroenReumkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question. Besides that looks perfect 🙏

Comment thread packages/ui/v2/modules/booker/DatePicker.tsx
@JeroenReumkens JeroenReumkens added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Nov 9, 2022
@kodiakhq kodiakhq Bot merged commit a73b3fc into main Nov 9, 2022
@kodiakhq kodiakhq Bot deleted the fix/format-calendar-month branch November 9, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CAL-338] Elements on Calendar Widget Localization Translation not Working

2 participants