Team billing#5453
Merged
Merged
Conversation
…into v2/teams-billing
…into v2/teams-billing
…into v2/teams-billing
Member
|
|
Member
|
I think it doesn't make sense for self-hosted: |
Member
|
|
| <Button color="secondary" href="/settings" className="w-full justify-center"> | ||
| {t("cancel")} | ||
| </Button> | ||
| <Button color="primary" type="submit" EndIcon={Icon.FiArrowRight} className="w-full justify-center"> |
Member
There was a problem hiding this comment.
Button doesn't have a loading state.
zomars
force-pushed
the
zomars/team-billing
branch
from
3413c48 to
7ee90e9
Compare
alannnc
approved these changes
Nov 10, 2022
Contributor
alannnc
left a comment
alannnc
left a comment
There was a problem hiding this comment.
Main path worked and I didn't run to any error. Didn't tested payment flow.
NIT:
- Would add a way to go back in create team flow.
- I didn't publish but I lost track of my entered slug, we could probably use another input instead of displaying it empty.
zomars
requested review from
JeroenReumkens,
PeerRich,
alannnc and
hariombalhara
Contributor
Author
|
Fixed tests and ready to re-review @calcom/reviewers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #5166
Following up efforts done in #5169
To minimize functionality differences between Cal.com and self-hosed we now allow for "unpublished" teams to exist.
These are teams that have a
nullslug. Which renders the publicly unaccessible (cannot permalink nor book events).You can still see them on you dashboard and add/remove members. But until you "publish" it the team will become publicly accessible.
On Cal this means that you need to checkout in order to publish. Self hosted can just publish a team without checkout.
Type of change
How should this be tested?
yarn e2e apps/web/playwright/teams.e2e.ts